]> dgit.raspbian.org Git - gnome-shell.git/commitdiff
animation: Disable spinner animations when actor is destroyed
authorFlorian Müllner <fmuellner@gnome.org>
Wed, 23 Jan 2019 22:40:18 +0000 (23:40 +0100)
committerFlorian Müllner <fmuellner@gnome.org>
Wed, 23 Jan 2019 23:20:58 +0000 (00:20 +0100)
There's nothing to animate anymore, just a source for warnings when
trying to access a destroyed object.

https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/362

js/ui/animation.js

index 5b4a10c085e4c13f9b93546734caac446e6bb0f3..65fff2cd72b4e6156e6f93edac9463381bf6a7b4 100644 (file)
@@ -104,6 +104,11 @@ var Spinner = new Lang.Class({
         this._animate = animate;
     },
 
+    _onDestroy() {
+        this._animate = false;
+        this.parent();
+    },
+
     play() {
         Tweener.removeTweens(this.actor);